Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.04.24 -> 2019.04.30 #60450

Merged
merged 1 commit into from Apr 30, 2019
Merged

youtube-dl: 2019.04.24 -> 2019.04.30 #60450

merged 1 commit into from Apr 30, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 30, 2019 •
edited

Motivation for this change

Update youtube-dl to the latest release.
https://github.com/ytdl-org/youtube-dl/releases/tag/2019.04.30
NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samueldr samueldr added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 30, 2019
@endgame
Copy link
Contributor

endgame commented Apr 30, 2019

Builds fine with:

nix build '(with import (builtins.fetchTarball { url = "https://github.com/xrelkd/nixpkgs/archive/update/youtube-dl.tar.gz"; }) {}; pkgs.youtube-dl)'

Seems to work (file opens with vlc):

$ ./result/bin/youtube-dl https://www.youtube.com/watch?v=dCFfgDrBycM
[youtube] dCFfgDrBycM: Downloading webpage
[youtube] dCFfgDrBycM: Downloading video info webpage
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
[download] Destination: Bowser's Jam (Quad City DJs vs Kondo & Mahito)-dCFfgDrBycM.f136.mp4
[download] 100% of 6.95MiB in 00:00
[download] Destination: Bowser's Jam (Quad City DJs vs Kondo & Mahito)-dCFfgDrBycM.f171.webm
[download] 100% of 3.44MiB in 00:13
[ffmpeg] Merging formats into "Bowser's Jam (Quad City DJs vs Kondo & Mahito)-dCFfgDrBycM.mkv"
Deleting original file Bowser's Jam (Quad City DJs vs Kondo & Mahito)-dCFfgDrBycM.f136.mp4 (pass -k to keep)
Deleting original file Bowser's Jam (Quad City DJs vs Kondo & Mahito)-dCFfgDrBycM.f171.webm (pass -k to keep)

endgame
endgame approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have merge privs but this looks good.

matthiasbeyer
matthiasbeyer approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@worldofpeace worldofpeace merged commit 366f70e into NixOS:master Apr 30, 2019
@worldofpeace
Copy link
Contributor

Backported in 6d7ed96

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 30, 2019

@samueldr @endgame @matthiasbeyer @worldofpeace Thank you!

@xrelkd xrelkd deleted the update/youtube-dl branch April 30, 2019 20:49
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame approved these changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xrelkd @endgame @worldofpeace @matthiasbeyer @samueldr