Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: add timokau as a maintainer #60368

Merged
merged 1 commit into from Apr 28, 2019
Merged

R: add timokau as a maintainer #60368

merged 1 commit into from Apr 28, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 28, 2019 •
edited

Motivation for this change

I'm interested in R as a dependency for sage. R changes are likely to
impact sage, so I'd like to get notified on those changes.

This is mostly to get ofBorg to ping me on PRs such as #60273.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
R: add timokau as a maintainer
31709b6 
I'm interested in R as a dependency for sage. R changes are likely to
impact sage, so I'd like to get notified on those changes.
@timokau timokau requested a review from peti as a code owner April 28, 2019 11:22
@peti peti merged commit 9dd1bbc into NixOS:master Apr 28, 2019
@timokau timokau deleted the r-maintainer branch April 28, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @peti