Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Remove usage of isNull #60406

Merged
merged 1 commit into from May 18, 2019
Merged

treewide: Remove usage of isNull #60406

merged 1 commit into from May 18, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

isNull "is deprecated; just write e == null instead" says the Nix manual

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar requested changes Apr 29, 2019
View reviewed changes
nixos/maintainers/option-usages.nix Outdated Show resolved Hide resolved
nixos/modules/config/sysctl.nix Outdated Show resolved Hide resolved
nixos/modules/installer/cd-dvd/iso-image.nix Outdated Show resolved Hide resolved
nixos/modules/services/cluster/kubernetes/kubelet.nix Outdated Show resolved Hide resolved
nixos/modules/services/cluster/kubernetes/kubelet.nix Outdated Show resolved Hide resolved
nixos/modules/services/continuous-integration/buildkite-agent.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/cassandra.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/cassandra.nix Outdated Show resolved Hide resolved
@JohnAZoidberg JohnAZoidberg force-pushed the remove-isnull branch 3 times, most recently from e32e234 to cc687a7 Compare April 29, 2019 08:16
Profpatsch
Profpatsch approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all changes, looks good.

@Profpatsch Profpatsch requested review from jtojnar and removed request for basvandijk, edolstra and nbp April 29, 2019 10:49
jtojnar
jtojnar reviewed Apr 29, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the parens, unless necessary for clarity.

nixos/modules/services/logging/logcheck.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/cockroachdb.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/dovecot.nix Outdated Show resolved Hide resolved
@JohnAZoidberg
treewide: Remove usage of isNull
786f02f 
isNull "is deprecated; just write e == null instead" says the Nix manual
@globin globin merged commit 6cf583c into NixOS:master May 18, 2019
@JohnAZoidberg JohnAZoidberg deleted the remove-isnull branch May 18, 2019 09:40
@infinisil infinisil mentioned this pull request Jul 17, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@Profpatsch Profpatsch Profpatsch approved these changes

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: emacs 6.topic: haskell 6.topic: nixos 6.topic: stdenv Standard environment 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohnAZoidberg @jtojnar @Profpatsch @globin