Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernkonzept ham #60425

Merged
merged 7 commits into from Apr 30, 2019
Merged

Kernkonzept ham #60425

merged 7 commits into from Apr 30, 2019

Conversation

herrwiese
Copy link
Contributor

Motivation for this change

Add ham, a utility for managing big source code projects consisting of multiple, loosely-coupled Git repositories, like the L4Re operating system.

dependencies:
perlPackages.GitVersionCompare: init at 1.004
perlPackages.TestRequiresGit: init at 1.008
perlPackages.SystemCommand: init at 1.119
perlPackages.GitRepository: init at 1.323
perlPackages.XMLMini: init at 1.38

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 29, 2019 •
edited

@herrwiese How can I test using this tool?

Edit: historical reference this was #53817

@herrwiese
Copy link
Contributor Author

herrwiese commented Apr 29, 2019 •
edited

Sorry, I accidentally closed the old one. You can for example test it by checking out mentioned L4Re OS, see Getting the Fiasco and L4Re sources Using ham. Note to do this in a scratch directory, as ham will check out things in $PWD.

@worldofpeace worldofpeace merged commit c9d80de into NixOS:master Apr 30, 2019
@worldofpeace
Copy link
Contributor

Tested it and it worked fine ✔️

Thank you for contributing @herrwiese and for your patience ✨

@herrwiese
Copy link
Contributor Author

Many thanks! Is there any chance to get this into release-19.03? If so, what is the procedure (seperate PR with commits rebased on top of branch?)?

@herrwiese herrwiese deleted the kernkonzept-ham branch April 30, 2019 20:38
@worldofpeace
Copy link
Contributor

Yes we always accept new packages to stable releases @herrwiese.

The procedure is outlined in https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches
So just base your pr off release-19.03 and cherry-pick the commits from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@herrwiese @worldofpeace