Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[soundkonverter] init at 3.0.1 #60408

Merged
merged 1 commit into from May 2, 2019
Merged

[soundkonverter] init at 3.0.1 #60408

merged 1 commit into from May 2, 2019

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Apr 29, 2019 •
edited

Motivation for this change

backport of #57793 to stable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files after installing into an environment using nix-env -f ~/src/nixpkgs/default.nix -iA soundkonverter
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
[soundkonverter] init at 3.0.1
e028941 
(cherry picked from commit 7218dec)
@schmittlauch
Copy link
Member Author

@Mic92

@Mic92
Copy link
Member

Mic92 commented May 2, 2019

Please add yourself also to ofborg: NixOS/ofborg#357

@Mic92
Copy link
Member

Mic92 commented May 2, 2019

@GrahamcOfBorg build soundkonverter

schmittlauch added a commit to schmittlauch/ofborg that referenced this pull request May 2, 2019
@schmittlauch
extra-known-users: Add schmittlauch
0e394c3 
As requested by @Mic92 in NixOS/nixpkgs#60408 I am adding myself as a trusted user, so that OfBorg can automatically build on more platforms when testing my PRs.
@schmittlauch schmittlauch mentioned this pull request May 2, 2019
Merged
@schmittlauch
Copy link
Member Author

@Mic92 check NixOS/ofborg#359

@Mic92 Mic92 merged commit 915ce0f into NixOS:release-19.03 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmittlauch @Mic92