Fix #6507: Don't try to load invalid depots from older savegames #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GroupStatistics pool was not initialised before trying to delete vehicles (specifically, trams with no tram track)
…r bridges losing their type
PeterN
reviewed
Apr 27, 2019
|
Is there any possibility of vehicles being inside one of these invalid depots? |
|
Given we don't properly understand what caused the invalid depots, I can't be entirely sure. However, given all known "invalid depots" have been next to rails, and there aren't any connecting rails, I don't think so. As best as I can tell, they were depots that existed at some point, but were removed prior to saving, but somehow were still saved anyway |
|
Is there a way to check if any vehicles are (supposed to be) inside the depot before deleting it, and fail loading in that case? |
|
Wouldn't it fail in some other way if you try to delete a depot with vehicles in it? |
|
Probably overthinking it. Deal with other brokenness if it occurs, let's not preempt it. |
PeterN
approved these changes
Apr 29, 2019
LordAro
added
the
backport requested
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also another bug spotted along the way
And another cleanup
Fixes #6605 as well, as it appears to be duplicated