Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fastpair: force use of pytest_3 #60326

Merged
merged 1 commit into from May 7, 2019
Merged

pythonPackages.fastpair: force use of pytest_3 #60326

merged 1 commit into from May 7, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 27, 2019

Motivation for this change

Fix build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner April 27, 2019 15:02
worldofpeace
worldofpeace previously requested changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, see above comment though.

Can you also change the py.test command in the checkPhase to pytest?
It's the old command.

@risicle
Copy link
Contributor Author

risicle commented Apr 28, 2019

Can you also change the py.test command in the checkPhase to pytest?

Done

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python27Packages.fastpair python37Packages.fastpair python36Packages.fastpair

@worldofpeace worldofpeace dismissed their stale review April 28, 2019 15:11

resolved by author

@worldofpeace worldofpeace merged commit aba815d into NixOS:master May 7, 2019
@worldofpeace
Copy link
Contributor

Looks like I forgot to check if this one built for ofborg. If it ever looks like that happens feel free to ping me on that pr
(so many notifications to look after 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @worldofpeace