Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asana: 0.7.1 -> 0.8.2, disable for py3.7 #60323

Merged
merged 1 commit into from May 6, 2019
Merged

pythonPackages.asana: 0.7.1 -> 0.8.2, disable for py3.7 #60323

merged 1 commit into from May 6, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 27, 2019

Motivation for this change

Bump and "fix" python 3.7 package by disabling it for 3.7 (upstream reportedly doesn't support 3.7 yet, blocked on https://bugs.python.org/issue34226)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner April 27, 2019 14:33
@c0bw3b
Copy link
Contributor

c0bw3b commented May 6, 2019

@GrahamcOfBorg build python27Packages.asana python37Packages.asana

c0bw3b
c0bw3b approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 60323 1

1 package were build:
  • python27Packages.asana

@c0bw3b c0bw3b merged commit c910fe9 into NixOS:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @c0bw3b