Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-pi: add midi in/out support #60432

Closed
wants to merge 2 commits into from
Closed

sonic-pi: add midi in/out support #60432

wants to merge 2 commits into from

Conversation

c0deaddict
Copy link
Member

Motivation for this change

The official Sonic Pi distribution has support for Midi devices (in and out) but the version in nixpkgs did not have this. Missing was the osmid dependency (from (this repository)[https://github.com/llloret/osmid]). Since sonic-pi needs a specific version I have inlined this dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented May 6, 2019 •
edited

Wouldn't it be possible to init osmid as its own package and perform an explicit version override from sonic-pi if really necessary? Otherwise osmid exists in nixpkgs as a phantom package, inaccessible outside sonic-pi and without important metadata like license.

@c0deaddict
Copy link
Member Author

Yes, that's a good suggestion. I've made osmid a package in the last commit added to this PR.

@c0deaddict
Copy link
Member Author

Can someone approve and merge this PR? @risicle @Phlogistique @kamilchm

@c0deaddict c0deaddict requested a review from FRidh as a code owner July 12, 2019 08:10
@ofborg ofborg bot removed the 6.topic: python label Aug 25, 2019
@c0deaddict c0deaddict closed this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phlogistique Phlogistique Phlogistique approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0deaddict @risicle @Phlogistique