Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update echoip, switch to buildGoModule #60386

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Update echoip, switch to buildGoModule #60386

merged 3 commits into from
Sep 10, 2019
+9 −85

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit April 28, 2019 18:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 28, 2019
@rvolosatovs rvolosatovs force-pushed the update/echoip branch 2 times, most recently from 039f4a8 to f016ad5 Compare July 9, 2019 20:54
@rvolosatovs
Copy link
Member Author

Any update on this?

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 28, 2019 •
edited
Loading

So sorry to have let this sit for so long @rvolosatovs.

How about just emulate the output structure from buildGoPackage and have

outputs = [ "bin" "out" ];

and call it a day?

Or the other alternative mentioned that would break configs.

kalbasit
kalbasit reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the nitpick, it looks good to me.

Regarding the index.html location, I would put it in its own output knowing that it would break existing installations. If you feel that it would be too invasive, I would just leave it as-is in that case.

@ofborg ofborg bot requested a review from kalbasit September 5, 2019 19:12
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@worldofpeace worldofpeace merged commit 19bf73d into NixOS:master Sep 10, 2019
@worldofpeace
Copy link
Contributor

Thanks @rvolosatovs. My apologies also on the long stretch of communication that happened here.

@rvolosatovs rvolosatovs deleted the update/echoip branch September 10, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @worldofpeace @kalbasit @lheckemann