Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update echoip, switch to buildGoModule #60386

Merged
merged 3 commits into from Sep 10, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

Any update on this?

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 28, 2019

So sorry to have let this sit for so long @rvolosatovs.

How about just emulate the output structure from buildGoPackage and have

outputs = [ "bin" "out" ];

and call it a day?

Or the other alternative mentioned that would break configs.

Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the nitpick, it looks good to me.

Regarding the index.html location, I would put it in its own output knowing that it would break existing installations. If you feel that it would be too invasive, I would just leave it as-is in that case.

pkgs/servers/echoip/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

Thanks @rvolosatovs. My apologies also on the long stretch of communication that happened here.

@rvolosatovs rvolosatovs deleted the update/echoip branch September 10, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants