codimd: 1.2.0 -> 1.4.0, repackage with yarn2nix #60429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I didn't have a detailed look at this (yet), but that looks much simpler than our previous hackery :) |
|
Seems like this does in fact not work with hydra, I'll rework this accordingly 😕 |
|
Now using the most recent version of yarn2nix with hydra support and also rebased on master. @GrahamcOfBorg test codimd |
WilliButz
changed the title
Ma27
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
As the change drastically simplifies the complexity of the codimd-package itself, I'm all in favor of it 👍
However I guess that we should get feedback from some more folks that were involved in NPM packaging in the past regarding the (re)introduction of yarn2ni x:)
|
@GrahamcOfBorg test codimd |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(updated)
In this PR
yarn2nixis used as a replacement fornode2nixto package codimd, which significantly reduces the complexity of the package definition, thus reducing the overhead of package updates.CodiMD is now packaged with nodejs-10_x.
To avoid the implication of being the only yarn2nix, I added moretea/yarn2nix as
yarn2nix-moretea. The source is simply copied to nixpkgs so that hydra is able to build packages using mkYarnPackage.