-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Screenshot window (& simplify the about/help DropDown) #7550
Conversation
Don't modify project files by hand, just add the files in source.list and run projects/generate[.vbs] (there's also a generate project in the solution for MSVC). |
I did not modify the project files by hand. Those were auto-generated by my editor (VS2017), reason for it only being new for vs141. |
Yes, and there's also a TAB issue in toolbar_gui.cpp:1146 |
Hmm it seems you have an issue with |
Would you say setting the autocrlf option to false fixes that issue? |
|
Needs a rebase. Looking at the window itself, I think I'd prefer more spacing between the buttons - it's very cramped as is |
I do think it would be worth getting this one through. Currently the screenshots bloat the about/help dropdown, and it's hard to reliably choose the intended screenshot type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per above, also needs rebase to fix merge of translation files.
Looks nice to me, thanks :) |
Sorry for being inactive, completely forgot about this PR. Thanks to LordAro for cleaning things up and that looks much better than before with the bigger buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only generate_widget was ran, running squirrel_export is needed after generate_widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shame about everything being squashed into a single commit, but no huge loss
Is the heightmap screenshot option allowed/supposed to be here? I remember it being for saving the heightmap of the loaded savegame in the scenario editor.
Though this is more for purposes for a better overview. Before the options were cramed together with "Toggle console", "AI/Game script debug"... options. Now they are split up into their own window.
Any code improvements are welcome as this is my first real code in C++ 😄.
Ideas:
Make the window close itself when a screenshot is taken?(Not really needed due to zoomed in and defaultzoom screenshots not showing the GUI anyway.)Make the above an option?Screenshots:

The new window:
The new version of the about/help DropDown:
