Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana_reporter: Fix library function name #60333

Merged
merged 1 commit into from May 3, 2019
Merged

grafana_reporter: Fix library function name #60333

merged 1 commit into from May 3, 2019

Conversation

azazel75
Copy link
Contributor

Motivation for this change

Fix the expression for package grafana_reporter, without this fix it is unusable in its current state

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Apr 27, 2019

Unfortunate that ofborg / tests didn't catch this.

@azazel75
Copy link
Contributor Author

azazel75 commented Apr 27, 2019 •
edited

@grahamc I thought that as well, but just adding a test that enables the service just to catch it seemed silly... but setting up a meaningful test seemed too much...

@infinisil infinisil merged commit bc5b262 into NixOS:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azazel75 @grahamc @infinisil