Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cubicsdr: init at 0.2.5 #60337

Merged
merged 1 commit into from Apr 29, 2019
Merged

cubicsdr: init at 0.2.5 #60337

merged 1 commit into from Apr 29, 2019

Conversation

lasandell
Copy link
Contributor

@lasandell lasandell commented Apr 27, 2019 •
edited

Motivation for this change

Nice GUI client for SoapySDR devices, including RTL-SDR. I'm also working on support for SDRPlay.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lasandell
Copy link
Contributor Author

lasandell commented Apr 27, 2019 •
edited

Need to resolve #60331 before merging this. Without wxWidgets 3.1.2, it gets an OpenGL error at startup and does not function [seems to still work in spite of that error].

markuskowa
markuskowa approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same OpenGL error, but it still works. Does the error disappear with the wxGTK update? Since it works, we could merge it independent of the wxGTK.

@lasandell
Copy link
Contributor Author

@markuskowa Yes, the wxGTK update gets rid of the error. I vote we go ahead and merge it, since I don't know if/when that update will be merged due to all the dependencies.

@markuskowa markuskowa merged commit 518e907 into NixOS:master Apr 29, 2019
@pmenke-de pmenke-de mentioned this pull request May 23, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lasandell @markuskowa