Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine{unstable,staging}: 4.6 -> 4.7 #60320

Merged
merged 2 commits into from May 1, 2019
Merged

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Apr 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completed a local nix-review

14 package were build:
pipelight playonlinux wine wineStaging wineMinimal wineStable winePackages.staging
wineUnstable wineWowPackages.base wineWowPackages.full wineWowPackages.minimal
wineWowPackages.staging wineWowPackages.unstable winetricks

$ ./results/playonlinux/bin/playonlinux --version
PlayOnLinux 4.3.4

@c0bw3b c0bw3b merged commit 8141d5b into NixOS:master May 1, 2019
@nyanloutre nyanloutre deleted the wine_update branch May 1, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants