Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxwidgets 3.1.0 -> 3.1.2 #60331

Closed
wants to merge 1 commit into from
Closed

wxwidgets 3.1.0 -> 3.1.2 #60331

wants to merge 1 commit into from

Conversation

lasandell
Copy link
Contributor

@lasandell lasandell commented Apr 27, 2019 •
edited

Motivation for this change

Need this dependency for another package I'm working on. 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

It might make sense to just get rid of the 3.0 package and put everything in the 3.1 directory. We'd need to verify everything still works though.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build wxGTK30 wxGTK31 pwsafe

@lasandell lasandell mentioned this pull request Apr 27, 2019
Merged
10 tasks
@lasandell
Copy link
Contributor Author

Looks like it's going to break things, unfortunately. I had to work around the fact that there was no --enable-compat26 flag in 3.1.2. Also looks like there is some error with --enable-universal-binaries missing on x86_64-darwin.

@lasandell lasandell closed this Aug 26, 2019
@lasandell
Copy link
Contributor Author

lasandell commented Aug 26, 2019 •
edited

Resolved by #63423

@lasandell lasandell deleted the wxwidgets-3.1.2 branch August 26, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lasandell @matthewbauer