Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openafs: 1.8.2 -> 1.8.3 #60463

Merged
merged 1 commit into from May 11, 2019
Merged

openafs: 1.8.2 -> 1.8.3 #60463

merged 1 commit into from May 11, 2019

Conversation

spacefrogg
Copy link
Contributor

@spacefrogg spacefrogg commented Apr 30, 2019 •
edited

Motivation for this change

General improvements and stability fixes coming from upstream. Upstream now includes necessary changes for newest kernels.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Verified that it builds against the current linuxPackages_latest

@ofborg ofborg bot requested a review from maggesi April 30, 2019 06:47
matthiasbeyer
matthiasbeyer approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@nlewo
Copy link
Member

nlewo commented May 5, 2019

@GrahamcOfBorg build openafs

@spacefrogg
Copy link
Contributor Author

@nlewo That was the wrong package. The right packages are openafs_1_8 and linuxPackages.openafs_1_8.

@nlewo
Copy link
Member

nlewo commented May 7, 2019

@spacefrogg oups :/
@GrahamcOfBorg build openafs_1_8 linuxPackages.openafs_1_8

@nlewo nlewo merged commit 021f127 into NixOS:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@maggesi maggesi Awaiting requested review from maggesi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spacefrogg @nlewo @matthiasbeyer