Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghq: 0.8.0 -> 0.10.2 #60391

Merged
merged 1 commit into from May 2, 2019
Merged

ghq: 0.8.0 -> 0.10.2 #60391

merged 1 commit into from May 2, 2019

Conversation

cohei
Copy link
Contributor

@cohei cohei commented Apr 28, 2019

Motivation for this change

To use newer version of ghq.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

@GrahamcOfBorg build ghq

@cohei
Copy link
Contributor Author

cohei commented Apr 30, 2019

On macOS 10.14.4, when I tried to build ghq 0.10.2 with the command:

$ nix-build -A ghq --option sandbox true

I got this error:

unpacking source archive /nix/store/0dc9h8wq2njmlqmbpnfinddndkz7vbci-go1.12.1.src.tar.gz
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/k8vwg7kzd4f0nwnpmjy3i1zbjqivaz69-gnutar-1.32/bin/tar
  Reason: no suitable image found.  Did find:
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/bv4w6nsaab0x1j47ilb34figw9sg92dm-stdenv-darwin/setup: line 842: 16880 Abort trap: 6           tar xf "$fn"
do not know how to unpack source archive /nix/store/0dc9h8wq2njmlqmbpnfinddndkz7vbci-go1.12.1.src.tar.gz
builder for '/nix/store/y5f3zf9ixf1kmxsyl54r5rh4hj0n3jg2-go-1.12.1.drv' failed with exit code 1
cannot build derivation '/nix/store/28lgz6gx7947r3gnx3sa561hwyziql4r-ghq-0.10.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/28lgz6gx7947r3gnx3sa561hwyziql4r-ghq-0.10.2.drv' failed

The same error is occured by building go in sandbox.

$ nix-env --install go --option sandbox true
installing 'go-1.12.1'
these derivations will be built:
  /nix/store/y5f3zf9ixf1kmxsyl54r5rh4hj0n3jg2-go-1.12.1.drv
building '/nix/store/y5f3zf9ixf1kmxsyl54r5rh4hj0n3jg2-go-1.12.1.drv'...
unpacking sources
unpacking source archive /nix/store/0dc9h8wq2njmlqmbpnfinddndkz7vbci-go1.12.1.src.tar.gz
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/k8vwg7kzd4f0nwnpmjy3i1zbjqivaz69-gnutar-1.32/bin/tar
  Reason: no suitable image found.  Did find:
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/bv4w6nsaab0x1j47ilb34figw9sg92dm-stdenv-darwin/setup: line 842: 25489 Abort trap: 6           tar xf "$fn"
do not know how to unpack source archive /nix/store/0dc9h8wq2njmlqmbpnfinddndkz7vbci-go1.12.1.src.tar.gz
builder for '/nix/store/y5f3zf9ixf1kmxsyl54r5rh4hj0n3jg2-go-1.12.1.drv' failed with exit code 1
error: build of '/nix/store/y5f3zf9ixf1kmxsyl54r5rh4hj0n3jg2-go-1.12.1.drv' failed

So it seems the error is not specific for ghq. This might not be a problem?

Building ghq succeeds without sandbox.

Added:

nix-review causes the same error.

@cohei
Copy link
Contributor Author

cohei commented Apr 30, 2019

Ah, #56591 is the problem.

@alyssais alyssais merged commit bcd07bb into NixOS:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants