Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux-xpanes: init at 4.1.0 #60390

Merged
merged 1 commit into from Jan 4, 2020
Merged

tmux-xpanes: init at 4.1.0 #60390

merged 1 commit into from Jan 4, 2020

Conversation

monsieurp
Copy link
Member

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@monsieurp monsieurp force-pushed the new-tmux-panes branch 4 times, most recently from 4aa86df to e5d95f1 Compare April 30, 2019 08:13
@monsieurp
Copy link
Member Author

✔️

@monsieurp
Copy link
Member Author

@grahamc: Hi! Could you take a look at this PR if you get round to it? Thanks! :)

gazally
gazally reviewed Jul 13, 2019
View reviewed changes
Copy link
Contributor

@gazally gazally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this and tried out the ping example from the homepage and everything worked.

gazally
gazally reviewed Jul 13, 2019
View reviewed changes
pkgs/tools/misc/tmux-xpanes/default.nix
'';

meta = with stdenv.lib; {
description = "tmux-based terminal divider";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "tmux-based terminal divider";
description = "Awesome tmux-based terminal divider";

This is what they call it on their homepage, and it fits the CONTRIBUTING.md rule better.

@ryantm
Copy link
Member

ryantm commented Jan 4, 2020

@GrahamcOfBorg build tmux-xpanes

@ryantm ryantm merged commit ceb515d into NixOS:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@gazally gazally gazally left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@monsieurp @ryantm @teto @gazally