Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-12_x: 12.0.0 -> 12.1.0 #60430

Merged
merged 1 commit into from Apr 29, 2019
Merged

nodejs-12_x: 12.0.0 -> 12.1.0 #60430

merged 1 commit into from Apr 29, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Apr 29, 2019 •
edited

Motivation for this change

12.1.0 has been released

Follows #60130, which was also targeting staging.

Things done

Updated version and hash.

stanislas@nixpsla ~/nixpkgs> ./result/bin/node -v
v12.1.0
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Apr 29, 2019

LGTM, thanks! Shame have to send to staging, but that libuv bump was needed and forced the issue :).

@dtzWill dtzWill merged commit 84a1587 into NixOS:staging Apr 29, 2019
@angristan angristan deleted the nodejs-12_x branch April 29, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angristan @dtzWill