Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staruml: fix dependency libexpat.so.1 #60370

Merged
merged 2 commits into from Apr 28, 2019
Merged

staruml: fix dependency libexpat.so.1 #60370

merged 2 commits into from Apr 28, 2019

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Apr 28, 2019 •
edited

Motivation for this change

Fix missing shared library dependency libexpat.so.1.

Things done

Add package expat to its LD_LIBRARY_PATH for wrapping.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Before: 455599176 (434.49 MiB)
    • After: 464853368 (443.32 MiB)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 28, 2019

Could you also move dpkg to nativeBuildInputs please?
It's only needed to unpack the source .deb

c0bw3b
c0bw3b approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution to nixpkgs 👌

@c0bw3b c0bw3b merged commit 05d3d71 into NixOS:master Apr 28, 2019
@oxalica oxalica deleted the fix/staruml-deps branch August 14, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxalica @c0bw3b @Janik-Haag