Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runc: 1.0.0-rc7 -> 1.0.0-rc8 #60466

Merged
merged 1 commit into from May 5, 2019
Merged

runc: 1.0.0-rc7 -> 1.0.0-rc8 #60466

merged 1 commit into from May 5, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Apr 30, 2019 •
edited

Motivation for this change

Bump runc to latest security release : see release note.
Needs to be backport to 19.03 and maybe 18.09 ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
runc: 1.0.0-rc7 -> 1.0.0-rc8
c64087b 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
matthiasbeyer
matthiasbeyer approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@vdemeester
Copy link
Member Author

cc @offlinehacker @xeji

@nlewo
Copy link
Member

nlewo commented May 5, 2019

@GrahamcOfBorg test docker-tools

@nlewo
Copy link
Member

nlewo commented May 5, 2019

Once tests are green, I merge it and backport it to 19.03. However, runc on 18.09 is still on rc5 and I feel scared to introduce too much changes (rc6 is not a minor release...) on this branch.... so i don't plan to backport it to 18.09.

@nlewo nlewo merged commit cbb0a0c into NixOS:master May 5, 2019
@nlewo
Copy link
Member

nlewo commented May 5, 2019

Backported to 19.03 in 6e29f22

@vdemeester vdemeester deleted the update-runc branch May 5, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @nlewo @matthiasbeyer