Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua: add rapidjson, lua-toml and lua-messagepack to generated packages #60465

Merged
merged 1 commit into from Apr 30, 2019
Merged

lua: add rapidjson, lua-toml and lua-messagepack to generated packages #60465

merged 1 commit into from Apr 30, 2019

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Apr 30, 2019

Add few lua packages:

Tested on Lua 5.1/5.2/5.3/Luajit

@teto please merge

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Apr 30, 2019

@GrahamcOfBorg build luaPackages.lua-messagepack luaPackages.lua-toml luaPackages.rapidjson

@teto
Copy link
Member

teto commented Apr 30, 2019

we already have the lua mpack library. Would be nice to have some motivation for the plugins. Do you need them for your software etc ?

@lblasc
Copy link
Contributor Author

lblasc commented Apr 30, 2019

Hello @teto, thanks for looking into this. We use lua-messagepack extensively in our software, it is fast and pure Lua implementation of msgpack.

@teto teto merged commit 9f94def into NixOS:master Apr 30, 2019
@lblasc lblasc deleted the lua-packages branch April 30, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblasc @teto