Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for python caldav package #60374

Merged
merged 2 commits into from Apr 29, 2019
Merged

Added support for python caldav package #60374

merged 2 commits into from Apr 29, 2019

Conversation

marenz2569
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marenz2569 marenz2569 requested a review from FRidh as a code owner April 28, 2019 15:09
infinisil
infinisil requested changes Apr 28, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the commit message for adding the package to "pythonPackages.caldav: init at 0.6.0" as is convention

pkgs/development/python-modules/caldav/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/caldav/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@marenz2569
Copy link
Member Author

@infinisil I made all the requested changes.

@infinisil
Copy link
Member

@GrahamcOfBorg build python2.pkgs.caldav
@GrahamcOfBorg build python3.pkgs.caldav

@infinisil infinisil merged commit 36d5d30 into NixOS:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marenz2569 @infinisil