Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: dark mode css can be passed as argument #60375

Merged
merged 1 commit into from Jun 13, 2019
Merged

slack: dark mode css can be passed as argument #60375

merged 1 commit into from Jun 13, 2019

Conversation

anpryl
Copy link
Contributor

@anpryl anpryl commented Apr 28, 2019 •
edited

Motivation for this change

Slack package has a dark mode, but current CSS for dark mode is broken for "All threads".
I add an optional argument to derivation for CSS url.
Default CSS url is an old one, so it is backward compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@anpryl anpryl force-pushed the slack_dark_css_arg branch 2 times, most recently from 8e6939b to 23e65e4 Compare April 29, 2019 05:27
@JohnAZoidberg
Copy link
Member

Slack package has a dark mode, but current CSS for dark mode is broken for "All threads".
I add an optional argument to derivation for CSS url.
Default CSS url is an old one, so it is backward compatible.

What do you mean it's broken? Does the default url not work anymore? If it doesn't work, we don't need to be backwards compatible.

@anpryl
Copy link
Contributor Author

anpryl commented Apr 30, 2019

Slack package has a dark mode, but current CSS for dark mode is broken for "All threads".
I add an optional argument to derivation for CSS url.
Default CSS url is an old one, so it is backward compatible.

What do you mean it's broken? Does the default url not work anymore? If it doesn't work, we don't need to be backwards compatible.

Here is an issue laCour/slack-night-mode#218.
Personally I switched to fork.
But I don't think that all package users wants to switch to random fork.

@etu
Copy link
Contributor

etu commented May 1, 2019

What do you mean it's broken? Does the default url not work anymore? If it doesn't work, we don't need to be backwards compatible.

Upstream (of the dark mode) will probably fix the issues that currently exists after upstream (slack server side rendered html) broke the dark mode. But this would give more flexibility for the user of the derivation to "fix it" faster. I use dark mode myself at work and it's currently quite unusable on some pages.

And I think that this is a quite nice workaround to be able to patch it easily as a user of NixOS.

@etu
Copy link
Contributor

etu commented Jun 13, 2019

@anpryl Hey, could you rebase this on master? That would be great to solve the conflicts. Ping me when you done it so we can merge this PR :)

@anpryl
Copy link
Contributor Author

anpryl commented Jun 13, 2019

@etu rebased on master

@etu etu merged commit 3674ff0 into NixOS:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anpryl @JohnAZoidberg @etu