plex-media-player: remove custom desktopItem #60444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this and can confirm it builds and had two desktop items before and now has 1. I have not tested any binaries |
|
Great! The upstream desktop file is more fully featured anyways :) |
|
Is installing the icon necessary? I would expect them to install it on their own when they added a desktop file. Are the paths in the desktop file correct? Sometimes project hardcode |
|
Indeed, the install part is not needed, the icon is fine even after removing that part. There is no path in the desktop file: stanislas@nixpsla ~/nixpkgs> cat result/share/applications/plexmediaplayer.desktop
[Desktop Entry]
Version=1.0
Name=Plex Media Player
GenericName=Media Player
Comment=View your media
Exec=plexmediaplayer --fullscreen --tv
Icon=plexmediaplayer
Terminal=false
Type=Application
Categories=AudioVideo;Video;Player;TV;
Actions=TV;DesktopF;DesktopW;
[Desktop Action TV]
Name=TV
Exec=plexmediaplayer --fullscreen --tv
[Desktop Action DesktopF]
Name=Desktop [Fullscreen]
Exec=plexmediaplayer --fullscreen --desktop
[Desktop Action DesktopW]
Name=Desktop [Windowed]
Exec=plexmediaplayer --windowed --desktop |
worldofpeace
approved these changes
Apr 30, 2019
angristan
force-pushed
the
plex-media-player/fix-desktop-icons
branch
from
ed942fc
to
5f1dc02
Compare
|
It should be good now, I hope 🙂 |
|
✨ Thank you @angristan for contributing |
|
Thanks everyone for helping out! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #60437:
plex-media-playercomes with a working desktop file, so there is no need to add our own custom one unless we remove the original. Both seem to work fine, so let's keep it simple.Things done
makeDesktopItemdependencydesktopItem(plex-media-player.desktop)sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)