Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speech-denoiser: init at unstable-07-10-2019 #60445

Merged
merged 1 commit into from May 5, 2019
Merged

speech-denoiser: init at unstable-07-10-2019 #60445

merged 1 commit into from May 5, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 30, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented May 5, 2019

looks like we rnnoise-nu is included in a subdirectory and to avoid dealing with ltmain.sh & co, we could package it separately. Would you mind checking whether https://github.com/marsam/nixpkgs/commit/cd514de42df works for you?

@magnetophon
Copy link
Member Author

Thanks that works too, and is much more elegant!

@marsam
Copy link
Contributor

marsam commented May 5, 2019

@GrahamcOfBorg build speech-denoiser

@marsam marsam merged commit 1e8cf45 into NixOS:master May 5, 2019
@magnetophon magnetophon deleted the speech-denoiser branch May 6, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @marsam