New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rambox-pro: init at 1.1.2 #60380
rambox-pro: init at 1.1.2 #60380
Conversation
Initial package issues found and resolved - tested and installing cleanly from my end at this point. This is my first PR to nixpkgs so figuring some things out. :) |
pkgs/applications/networking/instant-messengers/rambox-pro/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/rambox-pro/default.nix
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your package definition should rather live inside a file pro.nix
under the existing rambox
directory.
And in all-packages.nix
you would call it like this:
rambox-pro = callPackage ../applications/networking/instant-messengers/rambox/pro.nix { };
It avoids creating another folder for variants of the same app
pkgs/applications/networking/instant-messengers/rambox-pro/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/rambox-pro/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/rambox-pro/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/rambox-pro/default.nix
Outdated
Show resolved
Hide resolved
…ault.nix Co-Authored-By: cawilliamson <home@chrisaw.com>
I've addressed this particular piece of feedback now - good call. 👍 |
Co-Authored-By: cawilliamson <home@chrisaw.com>
I think that's all of the changes you requested added now @c0bw3b :) |
LGTM! 😸 |
Motivation for this change
I use Rambox Pro extensively for my communication needs and whilst open source Rambox is packaged - the pro variant is not. I'd like to address this.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)