Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox-pro: init at 1.1.2 #60380

Merged
merged 11 commits into from May 1, 2019
Merged

rambox-pro: init at 1.1.2 #60380

merged 11 commits into from May 1, 2019

Conversation

cawilliamson
Copy link
Member

@cawilliamson cawilliamson commented Apr 28, 2019

Motivation for this change

I use Rambox Pro extensively for my communication needs and whilst open source Rambox is packaged - the pro variant is not. I'd like to address this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cawilliamson
Copy link
Member Author

Initial package issues found and resolved - tested and installing cleanly from my end at this point.

This is my first PR to nixpkgs so figuring some things out. :)

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package definition should rather live inside a file pro.nix under the existing rambox directory.

And in all-packages.nix you would call it like this:

rambox-pro = callPackage ../applications/networking/instant-messengers/rambox/pro.nix { };

It avoids creating another folder for variants of the same app

@cawilliamson
Copy link
Member Author

Your package definition should rather live inside a file pro.nix under the existing rambox directory.

And in all-packages.nix you would call it like this:

rambox-pro = callPackage ../applications/networking/instant-messengers/rambox/pro.nix { };

It avoids creating another folder for variants of the same app

I've addressed this particular piece of feedback now - good call. 👍

c0bw3b and others added 2 commits May 1, 2019 18:59
Co-Authored-By: cawilliamson <home@chrisaw.com>
@cawilliamson
Copy link
Member Author

I think that's all of the changes you requested added now @c0bw3b :)

@c0bw3b
Copy link
Contributor

c0bw3b commented May 1, 2019

LGTM! 😸
Thanks for the contribution to nixpkgs

@c0bw3b c0bw3b merged commit a63be6c into NixOS:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants