Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service-wrapper: 16.04.0 -> 19.04 #60379

Merged
merged 1 commit into from Apr 28, 2019
Merged

service-wrapper: 16.04.0 -> 19.04 #60379

merged 1 commit into from Apr 28, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Apr 28, 2019

Motivation for this change

Resync with upstream
+ make --version output consistent with derivation

cc @DerTim1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Apr 28, 2019 

$ ./result/bin/service --version
service ver. 19-04

 ./result/bin/service --status-all
UNIT                                                                                     LOAD   ACTIVE SUB       DESCRIPTION        
sys-devices-pci0000:00-0000:00:03.0-virtio0-net-enp0s3.device                            loaded active plugged   Virtio network device 

$ ./result/bin/service nscd status
● nscd.service - Name Service Cache Daemon
   Loaded: loaded (/nix/store/bxj40xzpmki04jqbxlyigz33j1vfgzpl-unit-nscd.service/nscd.service; enabled; vendor preset: enabled)
   Active: active (running) since

@dtzWill
Copy link
Member

dtzWill commented Apr 28, 2019

LGTM!

@dtzWill dtzWill merged commit 43b0f81 into NixOS:master Apr 28, 2019
@c0bw3b c0bw3b deleted the pkg/service-wrapper branch April 28, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @dtzWill