Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.PyChromecast: 3.2.0 -> 3.2.1 #60353

Closed
wants to merge 1 commit into from
Closed

python3Packages.PyChromecast: 3.2.0 -> 3.2.1 #60353

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 28, 2019

Motivation for this change

https://github.com/balloob/pychromecast/releases/tag/3.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner April 28, 2019 03:06
@FRidh
Copy link
Member

FRidh commented Apr 28, 2019

Unless you need this change quickly, please avoid creating PR's for patch releases of Python packages that are fetched with fetchPyPi. Every other week or so I update all of them.

@FRidh
Copy link
Member

FRidh commented Apr 28, 2019

@GrahamcOfBorg eval

@dtzWill
Copy link
Member Author

dtzWill commented Apr 28, 2019

Okay! Sorry about that, this can wait AFAIK! :)

@dtzWill dtzWill closed this Apr 28, 2019
@ofborg ofborg bot requested a review from abbradar April 28, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @FRidh