Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.formulahendry.auto-close-tag: init at 0.5.6 #60405

Merged
merged 2 commits into from May 23, 2019
Merged

vscode-extensions.formulahendry.auto-close-tag: init at 0.5.6 #60405

merged 2 commits into from May 23, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Add another QoL extension to vscode extensions.

All written in TS, should be consistent behavior across any vscode installation.

Followed level of meta detail to match similar packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

795.5K closure size

@jonringer
Copy link
Contributor Author

bump @veprbl @vdemeester

@veprbl
Copy link
Member

veprbl commented May 9, 2019

cc @eadwu

@veprbl veprbl merged commit 3055ae4 into NixOS:master May 23, 2019
@jonringer jonringer deleted the jonringer/add_vscode_autoclosetag branch May 23, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @veprbl @Janik-Haag