Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddy: remove 'bin' attribute #66857

Merged
merged 1 commit into from
Aug 19, 2019
Merged

caddy: remove 'bin' attribute #66857

merged 1 commit into from
Aug 19, 2019

Conversation

nrdxp
Copy link

@nrdxp nrdxp commented Aug 19, 2019

Motivation for this change

This service was broken because it attempts to call an attribute on the caddy package that does not exist, namely the 'bin' attribute. The writer was attempting to obtain a path to the nix store location. Removing the bin attribute and coercing the pkg directly to a string accomplishes this just fine.

This pull request fixes the service file and it builds again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
shuding Shu Ding
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 19, 2019
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Thank you for fixing this.

@mmahut mmahut merged commit f0d1db9 into NixOS:master Aug 19, 2019
@nrdxp nrdxp deleted the fix/caddy branch August 19, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants