Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: mark termonad and focuslist as unbroken #66858

Merged
merged 2 commits into from Aug 19, 2019
Merged

haskell: mark termonad and focuslist as unbroken #66858

merged 2 commits into from Aug 19, 2019

Conversation

cdepillabout
Copy link
Member

Motivation for this change

The haskell packages termonad and focuslist are able to be built successfully, so I am marking them as non-broken.

I think next time the hackage2nix script is run, it should regenerate the hackage-packages.nix file so that termonad and focuslist no longer have broken set to true.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.termonad

@infinisil infinisil merged commit b6a311c into NixOS:haskell-updates Aug 19, 2019
@infinisil
Copy link
Member

Thanks!

@cdepillabout cdepillabout deleted the mark-termonad-unbroken branch August 19, 2019 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @infinisil