Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dconf: cleanup #66860

Merged
merged 3 commits into from Aug 19, 2019
Merged

nixos/dconf: cleanup #66860

merged 3 commits into from Aug 19, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I really just want the modules to set environment.variables.GIO_EXTRA_MODULES
so we can do away with it entirely one day 馃槃

Perhaps I should do this for gvfs also.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
nixos/dconf: cleanup
918b7d5 
Add dconf to systemPackages and make GIO_EXTRA_MODULES
a list so it can actually merge.
@worldofpeace
nixos/gnome3: use programs.dconf
a7b5d61
@worldofpeace
nixos/pantheon: use programs.dconf
38c7d55
jtojnar
jtojnar approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

馃憤 on the gvfs.

@worldofpeace
Copy link
Contributor Author

Thanks @jtojnar, will have a PR for gvfs later today.

@worldofpeace worldofpeace merged commit 9125f51 into NixOS:master Aug 19, 2019
@worldofpeace worldofpeace deleted the dconf-update branch August 19, 2019 15:59
@jtojnar jtojnar mentioned this pull request Aug 19, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar