Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libosmocore: 1.1.0 -> 1.2.0 #66954

Merged
merged 1 commit into from Aug 19, 2019
Merged

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libosmocore/versions.

meta.description for libosmocore is: '"libosmocore"'.

meta.homepage for libosmocore is: '"https://github.com/osmocom/libosmocore"

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gnuradio-with-packages
gr-gsm
libosmocore

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/50pl0laqjn2261732dw2nzbwr60r4g9b-libosmocore-1.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A libosmocore https://github.com/r-ryantm/nixpkgs/archive/374033add2e0b8257cbf228e13e4df19cc18098c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/50pl0laqjn2261732dw2nzbwr60r4g9b-libosmocore-1.2.0
ls -la /nix/store/50pl0laqjn2261732dw2nzbwr60r4g9b-libosmocore-1.2.0/bin

cc @mogorman for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/libosmocore/versions
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit dccbd8c into NixOS:master Aug 19, 2019
@r-ryantm r-ryantm deleted the auto-update/libosmocore branch August 24, 2019 21:09
@pespin
Copy link

pespin commented Sep 20, 2019

Hi, talking from osmocom here [1]. Are the build related issues you used to have gone now with libosmocore 1.2.0? If not, can you share somewhere if you have to apply any patch or something is failing? I would love receiving more feedback in upstream regarding the issues you are having, either by submitting patches or opening bug reports.

[1] https://osmocom.org/issues/3722

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2019

@GrahamcOfBorg build libosmocore

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2019

@pespin it seems the build is just disabled on macOS now: https://github.com/NixOS/nixpkgs/runs/197374900

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2019

@pespin
Copy link

pespin commented Oct 3, 2019

Does last link mean you are building 1.2.0 now? is it building fine? do you need to patch it somehow?

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2019

@pespin we no longer build libosmocore for macOS, only for linux-based systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants