Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofumpt: Init at 2019-07-29 #66892

Merged
merged 1 commit into from Aug 26, 2019
Merged

gofumpt: Init at 2019-07-29 #66892

merged 1 commit into from Aug 26, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

New package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build gofumpt

@ofborg ofborg bot requested a review from kalbasit August 19, 2019 09:50
symphorien
symphorien reviewed Aug 19, 2019
View reviewed changes
pkgs/development/tools/gofumpt/default.nix

modSha256 = "1g7dkl60zwlk4q2gwx2780xys8rf2c4kqyy8gr99s5y342wsbx2g";

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a description ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

alexarice
alexarice reviewed Aug 20, 2019
View reviewed changes
pkgs/development/tools/gofumpt/default.nix Outdated
{ lib, buildGoModule, fetchFromGitHub }:

buildGoModule rec {
name = "gofumpt-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use pname = "gofumpt"; here instead?

pkgs/development/tools/gofumpt/default.nix Outdated

src = fetchFromGitHub {
owner = "mvdan";
repo = "gofumpt";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo = pname;

@rvolosatovs
Copy link
Member Author

@alexarice done!

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build gofumpt

@kalbasit kalbasit merged commit 3f4144c into NixOS:master Aug 26, 2019
@rvolosatovs rvolosatovs deleted the init/gofumpt branch August 26, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@alexarice alexarice alexarice left review comments

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @kalbasit @symphorien @alexarice