Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: 1.12.7 -> 1.12.9, 1.11.12 -> 1.11.13 #66894

Merged
merged 2 commits into from Aug 25, 2019
Merged

go: 1.12.7 -> 1.12.9, 1.11.12 -> 1.11.13 #66894

merged 2 commits into from Aug 25, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update
Supersedes #66595

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92 @fmpwizard

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build go go_1_11

@rvolosatovs rvolosatovs mentioned this pull request Aug 19, 2019
Closed
10 tasks
@ofborg ofborg bot requested review from Mic92 and cstrahan August 19, 2019 10:08
@kalbasit
Copy link
Member

@GrahamcOfBorg build pet jx

@kalbasit
Copy link
Member

@rvolosatovs mind splitting the commit into 2, one for go_1_11 and another one for go_1_12. I'll merge once it's done.

@Mic92 I intend to.merge this straight to master. Aside from building Go itself, the rest of the packages are not CPU heavy to compile. Sounds good to you?

@johanot
Copy link
Contributor

johanot commented Aug 24, 2019

@kalbasit do you plan on backporting 1.11.13 to 19.03 ? I know we are close to 19.09, but there are a couple of CVE's to patch.

rvolosatovs and others added 2 commits August 24, 2019 22:38
@rvolosatovs @fmpwizard
go: 1.11.12 -> 1.11.13
d989d52 
Co-authored-by: Diego Medina <fmpwizard@gmail.com>
@rvolosatovs @fmpwizard
go: 1.12.7 -> 1.12.9
ef67737 
Co-authored-by: Diego Medina <fmpwizard@gmail.com>
@rvolosatovs
Copy link
Member Author

@kalbasit done

@kalbasit
Copy link
Member

kalbasit commented Aug 25, 2019 •
edited

@johanot yes I think we should do that. @rvolosatovs do you mind filing a PR against 19.03?

@kalbasit kalbasit merged commit 3d29aa1 into NixOS:master Aug 25, 2019
@rvolosatovs rvolosatovs deleted the update/go branch August 26, 2019 00:11
@rvolosatovs
Copy link
Member Author

Will do!

@rvolosatovs rvolosatovs mentioned this pull request Aug 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
1.severity: security 6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @kalbasit @johanot @vcunat