Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano 3.2 -> 4.3 #66760

Merged
merged 2 commits into from Aug 17, 2019
Merged

nano 3.2 -> 4.3 #66760

merged 2 commits into from Aug 17, 2019

Conversation

LouisDK1
Copy link
Contributor

@LouisDK1 LouisDK1 commented Aug 17, 2019 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Jascha Geerds jascha@geerds.org, Joachim Fasting joachifm@fastmail.fm

@LouisDK1
Copy link
Contributor Author

This is my first pull req. I only attend to change ./pkgs/applications/editors/nano/default.nix

@ofborg ofborg bot requested a review from joachifm August 17, 2019 15:26
@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

@GrahamcOfBorg build nano

@mmahut mmahut merged commit efb0d11 into NixOS:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LouisDK1 @mmahut @Janik-Haag