Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: python3 runtime requires ncurses executables #66817

Merged
merged 1 commit into from Aug 18, 2019
Merged

kitty: python3 runtime requires ncurses executables #66817

merged 1 commit into from Aug 18, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 18, 2019 •
edited

Motivation for this change

infocmp from ncruses.dev is needed to copy kitty's terminfo e.g. to
a remote server: https://github.com/kovidgoyal/kitty/blob/3a5baf27224fbd3347d30b2290f7681287256b30/docs/faq.rst#id45

Fixes #66583

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 mentioned this pull request Aug 18, 2019
Closed
@FRidh
Copy link
Member

FRidh commented Aug 18, 2019

This will retain references to .dev outputs, but the increase in closure size is negligible it seems.

@Ma27
Copy link
Member Author

Ma27 commented Aug 18, 2019

According to nix path-info -S -h it's 557.9M vs 558.9M which is IMHO in an acceptable range.

@srhb
Copy link
Contributor

srhb commented Aug 18, 2019

Yeah, that doesn't seem like a lot.

@srhb srhb merged commit af55f23 into NixOS:master Aug 18, 2019
@Ma27 Ma27 deleted the kitty-ncurses branch August 18, 2019 16:23
@avdv avdv mentioned this pull request Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kitty term info copy does not work
3 participants
@Ma27 @FRidh @srhb