Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.2.1 -> 1.3.1 #66814

Merged
merged 2 commits into from Aug 18, 2019
Merged

matrix-synapse: 1.2.1 -> 1.3.1 #66814

merged 2 commits into from Aug 18, 2019

Conversation

mguentner
Copy link
Contributor

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mguentner
matrix-synapse: 1.2.1 -> 1.3.1
86a57e4
@mguentner
nixos/matrix-synapse: use notify instead of simple
dac8fe9 
Starting with 1.3.0, matrix-synapse supports notifying
systemd. Relevant PR: matrix-org/synapse#5732
@mguentner mguentner mentioned this pull request Aug 18, 2019
Closed
10 tasks
@pacien
Copy link
Contributor

pacien commented Aug 18, 2019

@ofborg build matrix-synapse
@ofborg build nixosTests.matrix-synapse

@ofborg ofborg bot requested a review from Ekleog August 18, 2019 08:01
pacien
pacien approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(The NixOS test times out because of PostgreSQL ; It's a known issue.)

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build matrix-synapse

WilliButz
WilliButz approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully switched to 1.3.1 with this, thank you 👍

@WilliButz WilliButz merged commit 4835f65 into NixOS:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

@WilliButz WilliButz WilliButz approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mguentner @pacien @mmahut @WilliButz