Fix #7188: check the validity of command callback for scripts #7701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
added
the
backport requested
|
This looks very correct, but I can't think of a (good) way to set up a test of it. The bug #7188 triggers if a script is reloaded after sending a command, before the command has been handled next tick, so some kind of single stepping mechanism? |
nielsmh
approved these changes
Sep 7, 2019
|
Turns out I was too quick in approving this, we all forgot to test it in multiplayer. There, the command handling adds some flags to the |
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Sep 7, 2019
LordAro
pushed a commit
that referenced
this pull request
Sep 7, 2019
LordAro
added
backported
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a script is reloaded while waiting for the result of a command, this result will be sent to the new instance, and as the new instance is not expecting it, it can result in a crash.