Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-desktop: rename .desktop file to match app_id #66899

Merged
merged 1 commit into from Aug 19, 2019
Merged

riot-desktop: rename .desktop file to match app_id #66899

merged 1 commit into from Aug 19, 2019

Conversation

lightbulbjim
Copy link
Contributor

@lightbulbjim lightbulbjim commented Aug 19, 2019 •
edited

Motivation for this change

Fixes the problem where the app icon would not show under Gnome/Wayland.

See https://honk.sigxcpu.org/con/GTK__and_the_application_id.html for context. In this case the app_id is riot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pacien @worldofpeace

@lightbulbjim
riot-desktop: rename .desktop file to match app_id
efa9be4 
Fixes the problem where the app icon would not show under
Gnome/Wayland.
@ofborg ofborg bot requested a review from worldofpeace August 19, 2019 11:07
worldofpeace
worldofpeace approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually had this exact diff in my fork and forgot to upstream it 👍

@worldofpeace worldofpeace merged commit 893b7b5 into NixOS:master Aug 19, 2019
@lightbulbjim lightbulbjim deleted the riot-icon branch August 19, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lightbulbjim @pacien @worldofpeace