Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-logical] computed logical margin/padding #18524

Merged

Conversation

ewilligers
Copy link
Contributor

padding-block, padding-inline resolved values have absolute lengths.
https://drafts.csswg.org/css-logical/#propdef-padding-block
https://drafts.csswg.org/cssom/#resolved-values

getComputedStyle() results are tested for the following properties:

  • padding-block-start
  • padding-block-end
  • padding-inline-start
  • padding-inline-end
  • padding-block
  • padding-inline

@ewilligers
Copy link
Contributor Author

ewilligers commented Aug 18, 2019

Blink and Safari fail the tests involving percentages: https://crbug.com/985765
Firefox and Safari fail the tests involving shorthands: https://bugzilla.mozilla.org/show_bug.cgi?id=137688

margin-block, padding-inline etc. resolved values have absolute lengths.
https://drafts.csswg.org/css-logical-1/#margin-properties
https://drafts.csswg.org/css-logical-1/#padding-properties
https://drafts.csswg.org/cssom/#resolved-values

getComputedStyle() results are tested for the following properties:
- margin-block-start
- margin-block-end
- margin-inline-start
- margin-inline-end
- margin-block
- margin-inline
- padding-block-start
- padding-block-end
- padding-inline-start
- padding-inline-end
- padding-block
- padding-inline
@ewilligers ewilligers changed the title [css-logical] getComputedStyle().paddingBlock [css-logical] computed logical margin/padding Aug 18, 2019
@ewilligers
Copy link
Contributor Author

Commit, and commit message, now updated to also cover logical margins.

Note negative margins are not tested as the spec allows variation: "Negative values for margin properties are allowed, but there may be implementation-specific limits."

@ewilligers ewilligers merged commit dc8eb46 into web-platform-tests:master Aug 19, 2019
@ewilligers ewilligers deleted the computed-logical-padding branch August 19, 2019 20:07
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
margin-block, padding-inline etc. resolved values have absolute lengths.
https://drafts.csswg.org/css-logical-1/#margin-properties
https://drafts.csswg.org/css-logical-1/#padding-properties
https://drafts.csswg.org/cssom/#resolved-values

getComputedStyle() results are tested for the following properties:
- margin-block-start
- margin-block-end
- margin-inline-start
- margin-inline-end
- margin-block
- margin-inline
- padding-block-start
- padding-block-end
- padding-inline-start
- padding-inline-end
- padding-block
- padding-inline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants