Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdata: enable cgroup accounting #66922

Merged
merged 1 commit into from Aug 29, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Aug 19, 2019

Motivation for this change

Fixes #29095

Not needed when #66984 get merged

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member Author

davidak commented Aug 19, 2019

I verified that cgroup accounting is actually enabled by:

  1. build test vm with [davidak:~/code/nixpkgs]$ nix-build nixos/tests/netdata.nix -A driver
  2. run test vm with result/bin/nixos-run-vms
  3. login as root (empty password)
  4. run systemd-cgtop (you should see RAM usage and maybe CPU when any process is doing anything)

Screenshot from 2019-08-19 16-29-07

@flokli
Copy link
Contributor

flokli commented Aug 19, 2019

@davidak can we add a generic test to nixos/tests/systemd.nix that checks if systemd.enableCgroupAccounting actually works, and to what extend?

@davidak
Copy link
Member Author

davidak commented Aug 19, 2019

@flokli sure, that would be great. but unrelated to this PR. can you create another issue or PR for that?

@davidak
Copy link
Member Author

davidak commented Aug 27, 2019

Fixed by #66984 \o/

@davidak davidak closed this Aug 27, 2019
@davidak davidak deleted the netdata_enableCgroupAccounting branch August 27, 2019 10:14
@flokli
Copy link
Contributor

flokli commented Aug 27, 2019 via email

@davidak davidak restored the netdata_enableCgroupAccounting branch August 27, 2019 16:40
@davidak
Copy link
Member Author

davidak commented Aug 27, 2019

@flokli good point!

@davidak davidak reopened this Aug 27, 2019
@flokli
Copy link
Contributor

flokli commented Aug 29, 2019

Thanks!

@flokli flokli merged commit 132a838 into NixOS:master Aug 29, 2019
@davidak davidak deleted the netdata_enableCgroupAccounting branch August 29, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable cgroup accounting
2 participants