Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt: fix build on aarch64 #66919

Merged
merged 1 commit into from
Aug 19, 2019
Merged

rustfmt: fix build on aarch64 #66919

merged 1 commit into from
Aug 19, 2019
+3 −0

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Aug 19, 2019 •
edited
Loading

Motivation for this change

This fixes the build of rustfmt on aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build rustfmt

@ofborg ofborg bot added the 6.topic: rust label Aug 19, 2019
@ofborg ofborg bot requested a review from globin August 19, 2019 13:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 19, 2019
@basvandijk basvandijk marked this pull request as ready for review August 19, 2019 13:50
@basvandijk basvandijk requested review from LnL7 and Mic92 as code owners August 19, 2019 13:50
@globin globin merged commit cb1b949 into NixOS:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin

@LnL7 LnL7

@Mic92 Mic92

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @globin