Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directfb: fix build on ARM #66861

Merged
merged 2 commits into from Aug 19, 2019
Merged

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

directfb does not currently build on ARM and its source URL is defunct.

Things done

I was initially going to apply the patch that Debian uses to fix this issue, but I noticed that the source URL is not longer valid. tarballs.nixos.org has a copy, which prevented anyone from noticing that it disappeared. The directfb.org domain expired and was taken over by a squatter a couple of years ago.

The main author of the package created a repository on GitHub, so I switched the package to use that instead. This required adding a package for the flux compiler, which was previously run when creating the tarball.

Switching to the GitHub source had the side effect of adding the file that was missing from the autotools created tarball, fixing the build on ARM.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor

This has the side effect of fixing the build on ARM, because some required
files were missing from the tarball.
@matthewbauer matthewbauer merged commit 4497bee into NixOS:master Aug 19, 2019
@lopsided98 lopsided98 deleted the directfb-src-github branch August 19, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants