Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst_all_1.gst-plugins-base: fix build on ARM #66862

Merged
merged 1 commit into from Aug 31, 2019
Merged

gst_all_1.gst-plugins-base: fix build on ARM #66862

merged 1 commit into from Aug 31, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

gst-plugins-base does not build on ARM.

Things done

Added libGL to build inputs, as the configure script complained that it could not find it. I assume that libGL somehow gets propagated on other architectures.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

@ofborg ofborg bot requested a review from matthewbauer August 19, 2019 03:38
@worldofpeace
Copy link
Contributor

Mass rebuild on linux, should target staging.

@lopsided98
Copy link
Contributor Author

lopsided98 commented Aug 19, 2019 •
edited

@worldofpeace Is there any way to switch branches without notifying a ton of people?

@worldofpeace
Copy link
Contributor

I think if you base it off a revision that's likely to be based off the same commits as master it won't do that. But we're all pretty used to it at this point 😄

@lopsided98 lopsided98 changed the base branch from master to staging August 19, 2019 23:41
@FRidh FRidh merged commit dc74568 into NixOS:staging Aug 31, 2019
@lopsided98 lopsided98 deleted the gst-plugins-base-arm branch September 1, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @worldofpeace @FRidh