freetype: Remove unnecessary --disable-static.
#66763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The true-by-default `dontDisableStatic` already takes care of it. Fixes freetype not being overridable to have static libs.
nh2
added a commit
to nh2/static-haskell-nix
that referenced
this pull request
Aug 17, 2019
Requires nixpkgs submodule update submodule to fix `dontDisableStatic` not working on `freetype`, see NixOS/nixpkgs#66763.
matthewbauer
approved these changes
Aug 17, 2019
nh2
added a commit
to nh2/static-haskell-nix
that referenced
this pull request
Aug 17, 2019
Requires nixpkgs submodule update submodule to fix `dontDisableStatic` not working on `freetype`, see NixOS/nixpkgs#66763.
nh2
added a commit
to nh2/static-haskell-nix
that referenced
this pull request
Aug 17, 2019
Requires nixpkgs submodule update submodule to fix `dontDisableStatic` not working on `freetype`, see NixOS/nixpkgs#66763.
|
Hmm, |
nh2
added a commit
to nh2/static-haskell-nix
that referenced
this pull request
Oct 20, 2019
Requires nixpkgs submodule update submodule to fix `dontDisableStatic` not working on `freetype`, see NixOS/nixpkgs#66763.
nh2
added a commit
to nh2/static-haskell-nix
that referenced
this pull request
Oct 20, 2019
Requires nixpkgs submodule update submodule to fix `dontDisableStatic` not working on `freetype`, see NixOS/nixpkgs#66763.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The true-by-default
dontDisableStaticalready takes care of it.Fixes freetype not being overridable to have static libs.
This is the most pressing one of the fixes in #66759 (which is for
staging, this is formaster), because man GUI apps requirefreetypeso it's a big blocker for statically linking them whendontDisableStaticdoesn't work due to the hardcode.Found via nh2/static-haskell-nix#47.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @ttuegel
cc @matthewbauer @dtzWill @Ericson2314