Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-sitter: init at 0.15.7 #66758

Merged
merged 1 commit into from Aug 24, 2019
Merged

tree-sitter: init at 0.15.7 #66758

merged 1 commit into from Aug 24, 2019

Conversation

Profpatsch
Copy link
Member

Motivation for this change

init tree-sitter cli tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Aug 17, 2019
View reviewed changes
pkgs/development/tools/parsing/tree-sitter/default.nix Outdated
# sha256 = sha256Wasm;
# };

# print all the grammar names mentioned in the fetch-fixtures script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move, for clarity, the parts related to updating the grammar into a separate .nix file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, see force push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… and the other push, were I actually add the new file.

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build tree-sitter

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build tree-sitter

@Profpatsch
Copy link
Member Author

Not sure there’s official support for aarch/darwin right now, the tool compiles some C stuff, probably with totally wrong compiler arguments, tbd.

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build tree-sitter

timokau
timokau reviewed Aug 18, 2019
View reviewed changes
pkgs/development/tools/parsing/tree-sitter/0001-cli-disable-web-ui.patch Outdated
@@ -0,0 +1,41 @@
From b0862845bbeac903ebb32308cc22b691ba76ed9d Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is redundant?

@Profpatsch
Copy link
Member Author

The tests always segfault in different tests, pretty sure that’s a race condition.

Building works flawlessly on NixOS, merging. We can disable the test suite conditionally should it also fail on hydra.

@Profpatsch Profpatsch merged commit ffbad0f into NixOS:master Aug 24, 2019
@teto teto mentioned this pull request Dec 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@timokau timokau timokau left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Profpatsch @FRidh @timokau