Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 948025bca464
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4b90f549ee4e
Choose a head ref
  • 9 commits
  • 8 files changed
  • 1 contributor

Commits on Aug 19, 2019

  1. Unverified

    This user has not yet uploaded their public signing key.
    Copy the full SHA
    67ad8a7 View commit details
  2. Unverified

    This user has not yet uploaded their public signing key.
    Copy the full SHA
    eb127d2 View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    4bb6625 View commit details
  4. Copy the full SHA
    5b09814 View commit details
  5. Copy the full SHA
    a686dc0 View commit details
  6. Copy the full SHA
    45eac05 View commit details
  7. Copy the full SHA
    5c5791c View commit details
  8. Copy the full SHA
    ffe7999 View commit details
  9. Merge pull request #66956 from worldofpeace/cleanup-gvfs-envars

    nixos/gvfs: set GIO_EXTRA_MODULES
    worldofpeace authored Aug 19, 2019
    Copy the full SHA
    4b90f54 View commit details
2 changes: 1 addition & 1 deletion nixos/modules/module-list.nix
Original file line number Diff line number Diff line change
@@ -285,6 +285,7 @@
./services/desktops/flatpak.nix
./services/desktops/geoclue2.nix
./services/desktops/gsignond.nix
./services/desktops/gvfs.nix
./services/desktops/pipewire.nix
./services/desktops/gnome3/at-spi2-core.nix
./services/desktops/gnome3/chrome-gnome-shell.nix
@@ -297,7 +298,6 @@
./services/desktops/gnome3/gnome-settings-daemon.nix
./services/desktops/gnome3/gnome-terminal-server.nix
./services/desktops/gnome3/gnome-user-share.nix
./services/desktops/gnome3/gvfs.nix
./services/desktops/gnome3/rygel.nix
./services/desktops/gnome3/seahorse.nix
./services/desktops/gnome3/sushi.nix
43 changes: 0 additions & 43 deletions nixos/modules/services/desktops/gnome3/gvfs.nix

This file was deleted.

59 changes: 59 additions & 0 deletions nixos/modules/services/desktops/gvfs.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# GVfs

{ config, lib, pkgs, ... }:

with lib;

let

cfg = config.services.gvfs;

in

{

# Added 2019-08-19
imports = [
(mkRenamedOptionModule
[ "services" "gnome3" "gvfs" "enable" ]
[ "services" "gvfs" "enable" ])
];

###### interface

options = {

services.gvfs = {

enable = mkEnableOption "GVfs, a userspace virtual filesystem";

# gvfs can be built with multiple configurations
package = mkOption {
type = types.package;
default = pkgs.gnome3.gvfs;
description = "Which GVfs package to use.";
};

};

};


###### implementation

config = mkIf cfg.enable {

environment.systemPackages = [ cfg.package ];

services.dbus.packages = [ cfg.package ];

systemd.packages = [ cfg.package ];

services.udev.packages = [ pkgs.libmtp.bin ];

# Needed for unwrapped applications
environment.variables.GIO_EXTRA_MODULES = [ "${cfg.package}/lib/gio/modules" ];

};

}
4 changes: 1 addition & 3 deletions nixos/modules/services/x11/desktop-managers/gnome3.nix
Original file line number Diff line number Diff line change
@@ -138,7 +138,7 @@ in {
services.gnome3.gnome-settings-daemon.enable = true;
services.gnome3.gnome-terminal-server.enable = mkDefault true;
services.gnome3.gnome-user-share.enable = mkDefault true;
services.gnome3.gvfs.enable = true;
services.gvfs.enable = true;
services.gnome3.rygel.enable = mkDefault true;
services.gnome3.seahorse.enable = mkDefault true;
services.gnome3.sushi.enable = mkDefault true;
@@ -231,8 +231,6 @@ in {

services.xserver.updateDbusEnvironment = true;

environment.variables.GIO_EXTRA_MODULES = [ "${pkgs.gnome3.gvfs}/lib/gio/modules" ];

environment.systemPackages = pkgs.gnome3.corePackages ++ cfg.sessionPath
++ (pkgs.gnome3.removePackagesByName pkgs.gnome3.optionalPackages config.environment.gnome3.excludePackages) ++ [
pkgs.xdg-user-dirs # Update user dirs as described in http://freedesktop.org/wiki/Software/xdg-user-dirs/
3 changes: 2 additions & 1 deletion nixos/modules/services/x11/desktop-managers/lxqt.nix
Original file line number Diff line number Diff line change
@@ -58,7 +58,8 @@ in
# Link some extra directories in /run/current-system/software/share
environment.pathsToLink = [ "/share" ];

environment.variables.GIO_EXTRA_MODULES = [ "${pkgs.gvfs}/lib/gio/modules" ];
services.gvfs.enable = true;
services.gvfs.package = pkgs.gvfs;

services.upower.enable = config.powerManagement.enable;
};
4 changes: 1 addition & 3 deletions nixos/modules/services/x11/desktop-managers/mate.nix
Original file line number Diff line number Diff line change
@@ -98,13 +98,11 @@ in
services.gnome3.gnome-keyring.enable = true;
services.gnome3.gnome-settings-daemon.enable = true;
services.gnome3.gnome-settings-daemon.package = pkgs.mate.mate-settings-daemon;
services.gnome3.gvfs.enable = true;
services.gvfs.enable = true;
services.upower.enable = config.powerManagement.enable;

security.pam.services."mate-screensaver".unixAuth = true;

environment.variables.GIO_EXTRA_MODULES = [ "${pkgs.gnome3.gvfs}/lib/gio/modules" ];

environment.pathsToLink = [ "/share" ];
};

6 changes: 1 addition & 5 deletions nixos/modules/services/x11/desktop-managers/pantheon.nix
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@ in
services.gnome3.gnome-keyring.enable = true;
services.gnome3.gnome-settings-daemon.enable = true;
services.gnome3.gnome-settings-daemon.package = pkgs.pantheon.elementary-settings-daemon;
services.gnome3.gvfs.enable = true;
services.gvfs.enable = true;
services.gnome3.rygel.enable = mkDefault true;
services.gsignond.enable = mkDefault true;
services.gsignond.plugins = with pkgs.gsignondPlugins; [ lastfm mail oauth ];
@@ -162,10 +162,6 @@ in

environment.variables.GNOME_SESSION_DEBUG = optionalString cfg.debug "1";

environment.variables.GIO_EXTRA_MODULES = [
"${pkgs.gnome3.gvfs}/lib/gio/modules"
];

environment.pathsToLink = [
# FIXME: modules should link subdirs of `/share` rather than relying on this
"/share"
7 changes: 2 additions & 5 deletions nixos/modules/services/x11/desktop-managers/xfce.nix
Original file line number Diff line number Diff line change
@@ -66,7 +66,6 @@ in
exo
garcon
gtk-xfce-engine
gvfs
libxfce4ui
tumbler
xfconf
@@ -100,10 +99,6 @@ in
"/share/gtksourceview-2.0"
];

environment.variables = {
GIO_EXTRA_MODULES = [ "${pkgs.xfce.gvfs}/lib/gio/modules" ];
};

services.xserver.gdk-pixbuf.modulePackages = [ pkgs.librsvg ];

services.xserver.desktopManager.session = [{
@@ -128,5 +123,7 @@ in
# Enable helpful DBus services.
services.udisks2.enable = true;
services.upower.enable = config.powerManagement.enable;
services.gvfs.enable = true;
services.gvfs.package = pkgs.xfce.gvfs;
};
}